Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sepolia test network #34

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Conversation

oehm-smith
Copy link
Contributor

@oehm-smith oehm-smith commented Feb 24, 2024

Add Sepolia test network

Issue ticket number and link

na

Checklist before requesting a review

  • I have performed a self-review of my code
  • [na ] If it is a core feature, I have added thorough tests.
  • Will this be part of a product update? If yes, please write one phrase about this update.

This feature adds the Sepolia Ethereum test network so that it can be chosen when the user chooses 'Connect Wallet'.

@huseyindeniz
Copy link
Owner

Thank you very much the PR @oehm-smith ,

If it's not too much to ask, could you update the version in 2 locations.

  1. package.json line 4: "version": "0.5.4",
  2. Copyright.tsx line 11: <Tooltip label="Powered by React dApp Template (Vite) v0.5.4">

Side note: I definitely need to automate versioning.

src/features/wallet/assets/images/chains/11155111.webp Outdated Show resolved Hide resolved
src/features/wallet/chains/sepolia.ts Outdated Show resolved Hide resolved
src/features/wallet/chains/sepolia.ts Outdated Show resolved Hide resolved
@huseyindeniz
Copy link
Owner

I saw that linting is failing in 2 files:
Quick tip:
you can run npm run lint on your local to see linting errors
and you can run npm run lint -- --fix to fix them automatically
or you can fix them manually inside the file by using VS Code context menu:

image

@oehm-smith
Copy link
Contributor Author

I'll look at these things.

@oehm-smith
Copy link
Contributor Author

Changes performed and pushed.

Copy link
Owner

@huseyindeniz huseyindeniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok me. thanks for the effort @oehm-smith

@huseyindeniz huseyindeniz merged commit ec2e3d8 into huseyindeniz:main Mar 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants