[Examples] Add word count and pagerank #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuzhen11
changed the title
kygx-legend
changed the title
kygx-legend
requested changes
May 5, 2017
backend/python_connector.cpp
Outdated
| @@ -80,7 +80,7 @@ void PythonConnector::start_python_proc(int lid, int gid, int num_workers) { | |||
| std::string master_port = std::to_string(Context::get_config().get_master_port()); | |||
| std::string proc_id = std::to_string(Context::get_worker_info().get_process_id()); | |||
| extern_py_proc = | |||
| popen(("python -m pyhusky.backend.python_backend " + std::to_string(lid) + " " + std::to_string(gid) + " " + | |||
| popen(("python -m python.pyhusky.backend.python_backend " + std::to_string(lid) + " " + std::to_string(gid) + " " + | |||
There was a problem hiding this comment.
No need to change this. By default, $PYTHONPATH in readme includes python dir.
backend/register.cpp
Outdated
| @@ -17,6 +17,8 @@ | |||
| #include "backend/library/functional.hpp" | |||
| #include "backend/library/linear_regression.hpp" | |||
| #include "backend/library/logistic_regression.hpp" | |||
| #include "backend/library/word.hpp" | |||
| @@ -16,8 +16,8 @@ | |||
|
|
|||
| import cloudpickle | |||
|
|
|||
| from pyhusky.backend.globalvar import GlobalVar, GlobalSocket, OperationParam, GlobalN2NSocket | |||
| from pyhusky.common.serializers import Serializer | |||
| from python.pyhusky.backend.globalvar import GlobalVar, GlobalSocket, OperationParam, GlobalN2NSocket | |||
There was a problem hiding this comment.
I don't want to use the installed one. I met some problem during re-installation. The package cannot update. So instead I directly use the raw python file in the folder.
There was a problem hiding this comment.
Certainly yes for development. Then you don't need to use the installed method. A very simple way is to set env $PYTHONPATH like $ export PYTHONPATH=$PYHUSKY_ROOT/python and this is compatible with import pyhusky.*. Adding python.pyhusky is too ugly.
There was a problem hiding this comment.
Sorry for that I don't remember to add this into readme.
|
Ref #28 |
kygx-legend
approved these changes
May 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.