Merge the duplicate functions #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into a new function find_university
… into a new function find_university
|
为什么有两个一模一样的commit信息？ |
|
把原来的两个函数删了又重新commit了一次 |
|
已指定reviewers，请等待reviewer反馈 |
tttturtle-russ
requested changes
Oct 22, 2024
|
经过测试，这两个函数好像还不能合并 :( |
|
这样看来使用一个标志参数似乎是一个解决办法， @mudongliang @jxlpzqc 怎么看 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the duplicate functions is_university_domain and get_university into a new function find_university