Add BUILD_TOOLS option for building only libraries required by boolector. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpreiner
reviewed
Mar 4, 2024
mpreiner
approved these changes
Mar 5, 2024
|
@cr1901 I think it's waiting on you adding |
…tor. Signed-off-by: William D. Jones <[email protected]>
|
Whoops! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with YoWASP maintainer (@whitequark), we've decided this patch is better and supercedes/replaces #18. This PR adds a minimal build mode, so that only the minimum required dependencies for using
boolectorare built. This gets around the lack of WASM exceptions for the time being.Original Context:
I recently got boolector to successfully compile for WebAssembly.
I am using local patches for the time being, but this PR introduces my patches to upstream. This should be merged before the equivalent
boolectorPR.