Fixes and missing operator implementations for btorsim #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Btorsim already has an implementation for iff, but it wasn't marked as implemented. Signed-off-by: Ferdinand Bachmann <[email protected]>
The previous sra implementation wasn't working for negative inputs. The implementation was extracting the wrong sign bit (from b instead of a) and also accidently forgot to use it in the conditional, and used not_a instead. Signed-off-by: Ferdinand Bachmann <[email protected]>
This is a simple implementation delegating to sll and srl and or-ing the results together Signed-off-by: Ferdinand Bachmann <[email protected]>
Smod implementation taken from boolector (src/btorexp.c:1528) Signed-off-by: Ferdinand Bachmann <[email protected]>
|
sorry for the many edits to this PR yesterday; should be ready for review now |
mpreiner
reviewed
Aug 6, 2024
|
@Ferdi265 Thanks a lot for the additions/fixes! Sorry that it took so long for reviewing the PR. |
Signed-off-by: Ferdinand Bachmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the missing operations
iff,rol,ror, andsmodin btorsim and fixes the implementation forsra.Btorsim already has an implementation for iff, but it wasn't marked as implemented.
Implement rol and ror by delegating to sll and srl and or-ing the results together.
Smod implementation taken from boolector (src/btorexp.c:1528)
The previous sra implementation wasn't working for negative inputs. The implementation was extracting the wrong sign bit (from b instead of a) and also accidently forgot to use it in the conditional, and used not_a instead.
This fixes #22, fixes #23, and fixes #24