Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all(bluetooth): adaptors removed to prevent usage of tinygo #947

Closed

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Jun 4, 2023

Solved issues and/or description of the change

This is just a last resort to make module mode working with v2+ release, see #920 . Affected:

  • BLE
  • BLE-firmata
  • Microbit
  • Parrot-Minidrone
  • Sphero-BB8, Ollie, Sprkplus

Manual test

  • Linux

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a removed driver or adaptor:

  • I have removed the names from the README.md
  • I have removed examples
  • I have run make examples_check

@gen2thomas gen2thomas marked this pull request as ready for review June 5, 2023 17:51
@deadprogram
Copy link
Member

This is part of Gobot I really quite need. 😿

@gen2thomas
Copy link
Collaborator Author

Hi @deadprogram , by prevention of "tinygo/bluetooth" we will lose support for some adaptors, more than I thought. I'm also sad about this. Nevertheless I would test the effect for release of v2+.

If it works, I will create a new issue for restoring the files. Maybe we can implement a mock package in this case, so the user is able to fast switch to the real implementation.

If the test is not working, I will restore it immediately and go forward with the v3 approach.

I would do this (merge , release, test, restore/issue) within one or two days until end of this week.

@deadprogram
Copy link
Member

I guess I still don't fully understand the issue. I thought I added the bluetooth package to a previous release before the whole 2.0 thing?

@deadprogram
Copy link
Member

deadprogram commented Jun 6, 2023

See #920 (comment)

I think this PR here is no longer needed.

@gen2thomas
Copy link
Collaborator Author

You are right, unfortunately we have not detected/fixed the root cause yet. Lets see what happen with v3 - if the problem still exist, I will try to implement a mock for tinygo/bluetooth.

@gen2thomas gen2thomas closed this Jun 6, 2023
@gen2thomas gen2thomas deleted the fix/remove_tinygo_references branch June 7, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants