Skip to content

Commit

Permalink
Merge branch 'new-asset-system' into vite-integration
Browse files Browse the repository at this point in the history
  • Loading branch information
caendesilva committed Nov 14, 2024
2 parents 91297e8 + 22c59bb commit 3687cea
Show file tree
Hide file tree
Showing 11 changed files with 47 additions and 45 deletions.
28 changes: 14 additions & 14 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion config/hyde.php
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,6 @@
// Should the dashboard show tips?
'tips' => true,
],

],

/*
Expand Down
6 changes: 5 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@tailwindcss/typography": "^0.5.15",
"autoprefixer": "^10.4.20",
"hydefront": "^3.3.0",
"postcss": "^8.4.47",
"postcss": "^8.4.49",
"prettier": "3.3.3",
"tailwindcss": "^3.4.14",
"vite": "^5.0.0"
Expand Down
1 change: 0 additions & 1 deletion packages/framework/config/hyde.php
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,6 @@
// Should the dashboard show tips?
'tips' => true,
],

],

/*
Expand Down
2 changes: 1 addition & 1 deletion packages/framework/src/Console/Commands/ServeCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ protected function configureOutput(): void
protected function printStartMessage(): void
{
$this->useBasicOutput()
? $this->output->writeln('<info>Starting the HydeRC server...</info> Press Ctrl+C to stop')
? $this->output->writeln('<info>Starting the HydeRC server...</info> Use Ctrl+C to stop')
: $this->console->printStartMessage($this->getHostSelection(), $this->getPortSelection(), $this->getEnvironmentVariables());
}

Expand Down
28 changes: 14 additions & 14 deletions packages/framework/tests/Feature/Commands/ServeCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ protected function setUp(): void
public function testHydeServeCommand()
{
$this->artisan('serve --no-ansi')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S localhost:8080 {$this->binaryPath()}");
Expand All @@ -37,7 +37,7 @@ public function testHydeServeCommand()
public function testHydeServeCommandWithPortOption()
{
$this->artisan('serve --no-ansi --port=8081')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S localhost:8081 {$this->binaryPath()}");
Expand All @@ -46,7 +46,7 @@ public function testHydeServeCommandWithPortOption()
public function testHydeServeCommandWithHostOption()
{
$this->artisan('serve --no-ansi --host=foo')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S foo:8080 {$this->binaryPath()}");
Expand All @@ -55,7 +55,7 @@ public function testHydeServeCommandWithHostOption()
public function testHydeServeCommandWithPortAndHostOption()
{
$this->artisan('serve --no-ansi --port=8081 --host=foo')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S foo:8081 {$this->binaryPath()}");
Expand All @@ -66,7 +66,7 @@ public function testHydeServeCommandWithPortDefinedInConfig()
config(['hyde.server.port' => 8081]);

$this->artisan('serve --no-ansi')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S localhost:8081 {$this->binaryPath()}");
Expand All @@ -77,7 +77,7 @@ public function testHydeServeCommandWithPortDefinedInConfigAndPortOption()
config(['hyde.server.port' => 8081]);

$this->artisan('serve --no-ansi --port=8082')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S localhost:8082 {$this->binaryPath()}");
Expand All @@ -88,7 +88,7 @@ public function testHydeServeCommandWithPortMissingInConfigAndPortOption()
config(['hyde.server.port' => null]);

$this->artisan('serve --no-ansi --port=8081')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S localhost:8081 {$this->binaryPath()}");
Expand All @@ -99,7 +99,7 @@ public function testHydeServeCommandWithHostDefinedInConfig()
config(['hyde.server.host' => 'foo']);

$this->artisan('serve --no-ansi')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S foo:8080 {$this->binaryPath()}");
Expand All @@ -110,7 +110,7 @@ public function testHydeServeCommandWithHostDefinedInConfigAndHostOption()
config(['hyde.server.host' => 'foo']);

$this->artisan('serve --no-ansi --host=bar')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S bar:8080 {$this->binaryPath()}");
Expand All @@ -121,7 +121,7 @@ public function testHydeServeCommandWithHostMissingInConfigAndHostOption()
config(['hyde.server.host' => null]);

$this->artisan('serve --no-ansi --host=foo')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);

Process::assertRan("php -S foo:8080 {$this->binaryPath()}");
Expand All @@ -133,7 +133,7 @@ public function testHydeServeCommandWithInvalidConfigValue()
config(['hyde.server.port' => 'foo']);

$this->artisan('serve --no-ansi')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);
}

Expand Down Expand Up @@ -164,7 +164,7 @@ public function testHydeServeCommandPassesThroughProcessOutput()
->andReturn($mockProcess);

$this->artisan('serve --no-ansi')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->expectsOutput('foo')
->assertExitCode(0);
}
Expand Down Expand Up @@ -220,7 +220,7 @@ public function testHydeServeCommandWithViteOption()
->andReturn($mockServerProcess);

$this->artisan('serve --no-ansi --vite')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->expectsOutput('server output')
->expectsOutput('vite latest output')
->assertExitCode(0);
Expand Down Expand Up @@ -261,7 +261,7 @@ public function testHydeServeCommandWithViteOptionButViteNotRunning()
->andReturn($mockServerProcess);

$this->artisan('serve --no-ansi --vite')
->expectsOutput('Starting the HydeRC server... Press Ctrl+C to stop')
->expectsOutput('Starting the HydeRC server... Use Ctrl+C to stop')
->assertExitCode(0);
}

Expand Down
16 changes: 8 additions & 8 deletions packages/hydefront/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/hydefront/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"homepage": "https://github.com/hydephp/hydefront#readme",
"devDependencies": {
"sass": "1.80.6"
"sass": "1.80.7"
},
"main": "dist/hyde.css"
}
2 changes: 1 addition & 1 deletion packages/realtime-compiler/src/ConsoleOutput.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ protected function formatLineForOutput(string $line): ?string

protected function formatServerStartedLine(string $line): string
{
return $this->formatLine(sprintf('PHP %s Development Server started. <span class="text-yellow-500">Press Ctrl+C to stop.</span>', PHP_VERSION), $this->parseDate($line), 'green-500');
return $this->formatLine(sprintf('PHP %s Development Server started. <span class="text-yellow-500">Use Ctrl+C to stop.</span>', PHP_VERSION), $this->parseDate($line), 'green-500');
}

protected function formatRequestLine(string $line): string
Expand Down
4 changes: 2 additions & 2 deletions vite.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default defineConfig({
},
build: {
outDir: '_media',
emptyOutDir: true,
emptyOutDir: false,
rollupOptions: {
input: [
resolve(__dirname, 'resources/assets/app.js'),
Expand All @@ -58,4 +58,4 @@ export default defineConfig({
}
}
}
});
});

0 comments on commit 3687cea

Please sign in to comment.