Refactor to use dataprovider attribute

hydephp · Dec 7, 2024 · 9784937 · 9784937
1 parent c4e9e05
commit 9784937
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/packages/framework/tests/Unit/HeadingRendererUnitTest.php b/packages/framework/tests/Unit/HeadingRendererUnitTest.php
@@ -14,6 +14,7 @@
 use League\CommonMark\Node\Node;
 use League\CommonMark\Renderer\ChildNodeRendererInterface;
 use Mockery;
+use PHPUnit\Framework\Attributes\TestWith;
 
 /**
  * @covers \Hyde\Markdown\Processing\HeadingRenderer
@@ -234,13 +235,14 @@ public function testPostProcessHandlesNoHeadingTags()
         $this->assertSame('<p>Paragraph</p>', (new HeadingRenderer())->postProcess($html));
     }
 
-    public function testHeadingIdentifierGeneration()
+    #[TestWith(['hello world', 'hello-world'])]
+    #[TestWith(['hello-world', 'hello-world'])]
+    #[TestWith(['hello_world', 'hello-world'])]
+    #[TestWith(['user@host', 'user-at-host'])]
+    #[TestWith(['', ''])]
+    public function testHeadingIdentifierGeneration(string $input, string $expected): void
     {
-        $this->assertSame('hello-world', HeadingRenderer::makeIdentifier('hello world'));
-        $this->assertSame('hello-world', HeadingRenderer::makeIdentifier('hello-world'));
-        $this->assertSame('hello-world', HeadingRenderer::makeIdentifier('hello_world'));
-        $this->assertSame('user-at-host', HeadingRenderer::makeIdentifier('user@host'));
-        $this->assertSame('', HeadingRenderer::makeIdentifier(''));
+        $this->assertSame($expected, HeadingRenderer::makeIdentifier($input));
     }
 
     protected function mockChildNodeRenderer(string $contents = 'Test Heading'): ChildNodeRendererInterface