Move up boolean expression to condition

Makes it more readable but has same semantics
hydephp · Nov 13, 2023 · abca991 · abca991
1 parent c03be1a
commit abca991
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/realtime-compiler/src/Http/BaseController.php b/packages/realtime-compiler/src/Http/BaseController.php
@@ -97,11 +97,11 @@ protected function generateCSRFToken(): string
 
     protected function validateCSRFToken(?string $suppliedToken): bool
     {
-        if ($suppliedToken === null) {
+        if ($suppliedToken === null || empty($_SESSION['csrf_token'])) {
             return false;
         }
 
-        return ! empty($_SESSION['csrf_token']) && hash_equals($_SESSION['csrf_token'], $suppliedToken);
+        return hash_equals($_SESSION['csrf_token'], $suppliedToken);
     }
 
     protected function writeToConsole(string $message, string $context = 'dashboard'): void