Cleanup and refactor code

hydephp · Dec 5, 2024 · b959d2d · b959d2d
1 parent 155c456
commit b959d2d
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/packages/framework/src/Markdown/Processing/HeadingRenderer.php b/packages/framework/src/Markdown/Processing/HeadingRenderer.php
@@ -70,18 +70,22 @@ public function postProcess(string $html): string
 
     protected function makeHeadingId(string $contents): string
     {
-        $identifier = Str::slug($contents);
+        $identifier = $this->ensureIdentifierIsUnique(Str::slug($contents));
 
-        // Check for duplicates in the tracker
-        $id = $identifier;
+        $this->headingRegistry[] = $identifier;
+
+        return $identifier;
+    }
+
+    protected function ensureIdentifierIsUnique(string $slug): string
+    {
+        $identifier = $slug;
         $suffix = 2;
-        while (in_array($id, $this->headingRegistry)) {
-            $id = $identifier.'-'.$suffix++;
-        }
 
-        // Record the ID in the tracker and return it
-        $this->headingRegistry[] = $id;
+        while (in_array($identifier, $this->headingRegistry)) {
+            $identifier = $slug.'-'.$suffix++;
+        }
 
-        return $id;
+        return $identifier;
     }
 }