Merge pull request #1756 from hydephp/remove-git-version-feature

Remove the Git version displays
hydephp · Jun 28, 2024 · c464a42 · c464a42
2 parents 3757b46 + a2dfeb8
commit c464a42
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 11 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -26,7 +26,7 @@ This serves two purposes:
 - Deprecated the global `unslash()` function, replaced with the existing namespaced `\Hyde\unslash()` function in https://github.com/hydephp/develop/pull/1753
 
 ### Removed
-- for now removed features.
+- The Git version is no longer displayed in the debug screen and dashboard in https://github.com/hydephp/develop/pull/1756
 
 ### Fixed
 - Fixed explicitly set front matter navigation group behavior being dependent on subdirectory configuration, fixing https://github.com/hydephp/develop/issues/1515 in https://github.com/hydephp/develop/pull/1703

diff --git a/packages/framework/src/Console/Commands/DebugCommand.php b/packages/framework/src/Console/Commands/DebugCommand.php
@@ -40,7 +40,6 @@ public function handle(): int
         $this->info('HydePHP Debug Screen');
         $this->newLine();
 
-        $this->comment('Git Version: '.(string) app('git.version'));
         $this->comment('Hyde Version: '.((InstalledVersions::isInstalled('hyde/hyde') ? InstalledVersions::getPrettyVersion('hyde/hyde') : null) ?: 'unreleased'));
         $this->comment('Framework Version: '.(InstalledVersions::getPrettyVersion('hyde/framework') ?: 'unreleased'));
         $this->newLine();

diff --git a/packages/framework/tests/Feature/Commands/DebugCommandTest.php b/packages/framework/tests/Feature/Commands/DebugCommandTest.php
@@ -15,13 +15,6 @@
  */
 class DebugCommandTest extends TestCase
 {
-    protected function setUp(): void
-    {
-        parent::setUp();
-
-        $this->app->bind('git.version', fn () => 'foo');
-    }
-
     public function testDebugCommandCanRun()
     {
         $this->artisan('debug')->assertExitCode(0);
@@ -31,7 +24,6 @@ public function testItPrintsDebugInformation()
     {
         $this->artisan('debug')
             ->expectsOutput('HydePHP Debug Screen')
-            ->expectsOutputToContain('Git Version:')
             ->expectsOutputToContain('Hyde Version:')
             ->expectsOutputToContain('Framework Version:')
             ->expectsOutputToContain('App Env:')

diff --git a/packages/realtime-compiler/src/Http/DashboardController.php b/packages/realtime-compiler/src/Http/DashboardController.php
@@ -122,7 +122,6 @@ public function getVersion(): string
     public function getProjectInformation(): array
     {
         return [
-            'Git Version' => app('git.version'),
             'Hyde Version' => self::getPackageVersion('hyde/hyde'),
             'Framework Version' => self::getPackageVersion('hyde/framework'),
             'Project Path' => Hyde::path(),