Merge pull request #1995 from hydephp/no-longer-save-realtime-compile…

…r-pages-by-default [2.x] Update default configuration to no longer save previewed pages
hydephp · Nov 5, 2024 · c4cbe6e · c4cbe6e
2 parents 4622237 + c58c7dc
commit c4cbe6e
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 15 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -51,6 +51,7 @@ This serves two purposes:
 - Minor: The `processing_time_ms` attribute in the `sitemap.xml` file has now been removed in https://github.com/hydephp/develop/pull/1744
 - Minor: Updated the `Hyde::url()` helper throw a `BadMethodCallException` instead `BaseUrlNotSetException` when no site URL is set and no path was provided to the method in https://github.com/hydephp/develop/pull/1760 and https://github.com/hydephp/develop/pull/1890
 - Minor: Updated the blog post layout and post feed component to use the `BlogPosting` Schema.org type instead of `Article` in https://github.com/hydephp/develop/pull/1887
+- Updated default configuration to no longer save previewed pages in https://github.com/hydephp/develop/pull/1995
 - Added more rich markup data to blog post components in https://github.com/hydephp/develop/pull/1888 (Note that this inevitably changes the HTML output of the blog post components, and that any customized templates will need to be republished to reflect these changes)
 - Overhauled the blog post author feature in https://github.com/hydephp/develop/pull/1782
 - Improved the sitemap data generation to be smarter and more dynamic in https://github.com/hydephp/develop/pull/1744

diff --git a/config/hyde.php b/config/hyde.php
@@ -423,7 +423,7 @@
         'host' => env('SERVER_HOST', 'localhost'),
 
         // Should preview pages be saved to the output directory?
-        'save_preview' => true,
+        'save_preview' => false,
 
         // Should the live edit feature be enabled?
         'live_edit' => env('SERVER_LIVE_EDIT', true),

diff --git a/docs/extensions/realtime-compiler.md b/docs/extensions/realtime-compiler.md
@@ -31,7 +31,7 @@ The server can be configured in the `config/hyde.php` file to change the port, h
 'server' => [
     'port' => env('SERVER_PORT', 8080),
     'host' => env('SERVER_HOST', 'localhost'),
-    'save_preview' => true,
+    'save_preview' => false,
 ],
 ```
 

diff --git a/packages/framework/config/hyde.php b/packages/framework/config/hyde.php
@@ -423,7 +423,7 @@
         'host' => env('SERVER_HOST', 'localhost'),
 
         // Should preview pages be saved to the output directory?
-        'save_preview' => true,
+        'save_preview' => false,
 
         // Should the live edit feature be enabled?
         'live_edit' => env('SERVER_LIVE_EDIT', true),

diff --git a/packages/realtime-compiler/tests/RealtimeCompilerTest.php b/packages/realtime-compiler/tests/RealtimeCompilerTest.php
@@ -49,11 +49,6 @@ public function testHandlesRoutesIndexPage()
         $this->assertEquals(200, $response->statusCode);
         $this->assertEquals('OK', $response->statusMessage);
         $this->assertStringContainsString('<title>Welcome to HydePHP!</title>', $response->body);
-
-        $this->assertFileExists(hyde()->path('_site/index.html'));
-        $this->assertEquals($response->body, Filesystem::get('_site/index.html'));
-
-        Filesystem::unlink('_site/index.html');
     }
 
     public function testHandlesRoutesCustomPages()
@@ -71,13 +66,10 @@ public function testHandlesRoutesCustomPages()
         $this->assertStringContainsString('<h1>Hello World!</h1>', $response->body);
 
         Filesystem::unlink('_pages/foo.md');
-        Filesystem::unlink('_site/foo.html');
     }
 
     public function testHandlesRoutesPagesWithHtmlExtension()
     {
-        $this->mockRoute('foo.html');
-
         Filesystem::put('_pages/foo.md', '# Hello World!');
 
         $kernel = new HttpKernel();
@@ -89,7 +81,6 @@ public function testHandlesRoutesPagesWithHtmlExtension()
         $this->assertStringContainsString('<h1>Hello World!</h1>', $response->body);
 
         Filesystem::unlink('_pages/foo.md');
-        Filesystem::unlink('_site/foo.html');
     }
 
     public function testHandlesRoutesStaticAssets()
@@ -144,7 +135,6 @@ public function testTrailingSlashesAreNormalizedFromRoute()
         $this->assertStringContainsString('<h1>Hello World!</h1>', $response->body);
 
         Filesystem::unlink('_pages/foo.md');
-        Filesystem::unlink('_site/foo.html');
     }
 
     public function testDocsUriPathIsReroutedToDocsIndex()
@@ -162,7 +152,6 @@ public function testDocsUriPathIsReroutedToDocsIndex()
         $this->assertStringContainsString('HydePHP Docs', $response->body);
 
         Filesystem::unlink('_docs/index.md');
-        Filesystem::unlink('_site/docs/index.html');
     }
 
     public function testDocsSearchRendersSearchPage()
@@ -179,7 +168,6 @@ public function testDocsSearchRendersSearchPage()
         $this->assertStringContainsString('Search the documentation site', $response->body);
 
         Filesystem::unlink('_docs/index.md');
-        Filesystem::unlink('_site/docs/search.html');
     }
 
     public function testPingRouteReturnsPingResponse()