Merge pull request #1459 from hydephp/realtime-compiler-code-cleanup

Refactor internal dashboard header handling
hydephp · Nov 13, 2023 · f849313 · f849313
2 parents 6230587 + 657a082
commit f849313
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/packages/realtime-compiler/resources/dashboard.js b/packages/realtime-compiler/resources/dashboard.js
@@ -21,7 +21,7 @@ function registerAsyncForm(form, okHandler = null, errorHandler = null, beforeCa
             method: "POST",
             body: new FormData(event.target),
             headers: new Headers({
-                "X-RC-Handler": "Async",
+                "Accept": "application/json",
             }),
         }).then(async response => {
             if (response.ok) {

diff --git a/packages/realtime-compiler/src/Http/BaseController.php b/packages/realtime-compiler/src/Http/BaseController.php
@@ -110,4 +110,9 @@ protected function writeToConsole(string $message, string $context = 'dashboard'
             $this->console->printMessage($message, $context);
         }
     }
+
+    protected function expectsJson(): bool
+    {
+        return array_change_key_case(getallheaders())['accept'] === 'application/json';
+    }
 }
diff --git a/packages/realtime-compiler/src/Http/DashboardController.php b/packages/realtime-compiler/src/Http/DashboardController.php
@@ -57,7 +57,7 @@ public function __construct(?Request $request = null)
         $this->loadFlashData();
 
         if ($this->request->method === 'POST') {
-            $this->isAsync = $this->hasAsyncHeaders();
+            $this->isAsync = $this->expectsJson();
         }
     }
 
@@ -464,9 +464,4 @@ protected function findGeneralOpenBinary(): string
             )
         };
     }
-
-    protected function hasAsyncHeaders(): bool
-    {
-        return (getallheaders()['X-RC-Handler'] ?? getallheaders()['x-rc-handler'] ?? null) === 'Async';
-    }
 }