Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataCollections methods should not create directories #1735

Closed
caendesilva opened this issue Jun 23, 2024 · 1 comment
Closed

DataCollections methods should not create directories #1735

caendesilva opened this issue Jun 23, 2024 · 1 comment

Comments

@caendesilva
Copy link
Member

It feels weird that this creates the directory, and it violates the principle of least astonishment as it's surprising that this creates a directory when you just request the path. This is related to #1706 which was fixed in #1706.

I think I remember why this was added: It was so that if the user added code to use an include or data collection we would make sure the directory exists, however, this is not obvious, and seemingly randomly creating directories is not intuitive. The performance impact is small, but not negligible (~0.3ms)

@caendesilva
Copy link
Member Author

Fixed in #1732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant