Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] DataCollections improvements #1732

Merged
merged 122 commits into from
Jun 25, 2024
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jun 23, 2024

See the 1.x tie-in to make the upgrade smoother #1733. Fixes #1712

Main changes:

Also adds increased unit testing for syntax options and fault tolerance

@caendesilva caendesilva force-pushed the 2x-datacollections-improvements branch from c6d28f1 to a2f4219 Compare June 23, 2024 14:44
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d87afde) to head (227db4f).

Current head 227db4f differs from pull request most recent head 0a3a65a

Please upload reports for the commit 0a3a65a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             2.x-dev    #1732   +/-   ##
==========================================
  Coverage      99.95%   99.95%           
- Complexity      1789     1806   +17     
==========================================
  Files            184      185    +1     
  Lines           4757     4786   +29     
==========================================
+ Hits            4755     4784   +29     
  Misses             2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva
Copy link
Member Author

Questioning if we should support --- at all, but they are valid (and recommended) spec so I can't justify the BC break of removing them. Still, only the first Yaml document in a file is valid, anything else will be trimmed, and I don't think it's common enough to try this to warrant an exception here. We do handle it gracefully by using Str::between (originally implemented to simplify logic to trim front matter encased Yaml with dashes both above and under)

@caendesilva caendesilva force-pushed the 2x-datacollections-improvements branch from a699637 to 1570c8b Compare June 24, 2024 08:06
@caendesilva caendesilva force-pushed the 2x-datacollections-improvements branch from ce6145c to 8fba6af Compare June 25, 2024 16:48
@caendesilva caendesilva marked this pull request as ready for review June 25, 2024 17:58
@caendesilva caendesilva merged commit 9ffeb70 into 2.x-dev Jun 25, 2024
7 checks passed
@caendesilva caendesilva deleted the 2x-datacollections-improvements branch June 25, 2024 17:58
@caendesilva caendesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant