-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] DataCollections improvements #1732
Conversation
c6d28f1
to
a2f4219
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1732 +/- ##
==========================================
Coverage 99.95% 99.95%
- Complexity 1789 1806 +17
==========================================
Files 184 185 +1
Lines 4757 4786 +29
==========================================
+ Hits 4755 4784 +29
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Questioning if we should support |
This reverts commit 5d655cb.
a699637
to
1570c8b
Compare
More verbose, but clearer, and probably more accurate. Has cases for the exceptions we throw this for.
This reverts commit 770df88.
ce6145c
to
8fba6af
Compare
See the 1.x tie-in to make the upgrade smoother #1733. Fixes #1712
Main changes:
DataCollections
toDataCollection
ParseException
exceptionAlso adds increased unit testing for syntax options and fault tolerance