Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove low priority todo comments #1408

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Remove low priority todo comments #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfe3732
Remove low priority todo comment from workflow
caendesilva Oct 28, 2023
8be4c36
Remove low priority todo comment from code
caendesilva Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/deploy-documentation-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
name: Deploy Documentation Preview

# TODO: Add check to only rerun if docs have changed since last run on the PR

on:
pull_request:
branches: [ "master" ]
Expand All @@ -11,7 +9,10 @@ on:
jobs:

build-documentation-preview:
if: "! contains(github.event.pull_request.labels.*.name, 'pause-pages')" ## Temporary until todo above is fixed
# We could add a check to only rerun if docs have changed since last run on the PR
# But this would require a state storage, and the current version is good enough.
if: "! contains(github.event.pull_request.labels.*.name, 'pause-pages')"

environment:
name: pr-documentation-${{ github.event.pull_request.number }}
url: https://hydephp.github.io/develop/pr-${{ github.event.pull_request.number }}/dev-docs-preview
Expand Down
4 changes: 1 addition & 3 deletions packages/framework/src/Framework/Features/Blogging/Models/FeaturedImage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,7 @@ protected function getContentLengthForLocalImage(): int

protected function getContentLengthForRemoteImage(): int
{
// TODO: We may want to globalize this check in the config, but for now,
// we just check the server arguments and skip remote requests if
// the --no-api flag is present (in the build command call)
// Check if the --no-api flag is set when running the build command, and if so, skip the API call.
caendesilva marked this conversation as resolved.
Show resolved Hide resolved
if (! (isset($_SERVER['argv']) && in_array('--no-api', $_SERVER['argv'], true))) {
$headers = Http::withHeaders([
'User-Agent' => Config::getString('hyde.http_user_agent', 'RSS Request Client'),
Expand Down
Loading