Support both route keys and identifiers for specifying sidebar order #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
caendesilva
commented
Nov 7, 2023
caendesilva
commented
- Supports route keys for consistency with the navigation config.
- Supports identifiers for backwards compatibility and ease of use, as the route key prefix is redundant due to it being the same for all documentation pages.
Will make the next refactor more readable
- Supports route keys for consistency with the navigation config. - Supports identifiers for backwards compatibility and ease of use, as the route key prefix is redundant due to it being the same for all documentation pages.
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1710 3418 +1708
=============================================
Files 180 360 +180
Lines 4640 9284 +4644
=============================================
+ Hits 4640 9284 +4644
|
caendesilva
deleted the
normalize-navigation-menu-configuration-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.