Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor console output internals #1447

Merged
merged 12 commits into from
Nov 11, 2023
Merged

Refactor console output internals #1447

merged 12 commits into from
Nov 11, 2023

Conversation

caendesilva
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #1447 (c4683db) into master (619655d) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master     #1447     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1717      3438   +1721     
=============================================
  Files            180       360    +180     
  Lines           4658      9324   +4666     
=============================================
+ Hits            4658      9324   +4666     
Files Coverage Δ
...es/framework/src/Console/Commands/ServeCommand.php 100.00% <100.00%> (ø)

... and 180 files with indirect coverage changes

In case something like Herd or a hosts file is used, this then supports SSL/TLS URLs when providing an HTTPS host.
@caendesilva caendesilva marked this pull request as ready for review November 11, 2023 10:43
@caendesilva caendesilva merged commit cd9add2 into master Nov 11, 2023
19 checks passed
@caendesilva caendesilva deleted the fancy-serve-command branch November 11, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant