Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy serve command cleanup #1449

Merged
merged 5 commits into from
Nov 11, 2023
Merged

Fancy serve command cleanup #1449

merged 5 commits into from
Nov 11, 2023

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva marked this pull request as ready for review November 11, 2023 12:31
This reverts commit c3aba72 as this is needed to have the option values default to null while giving the documented value of the inferred values.
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #1449 (afca62e) into master (d325a10) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##              master     #1449     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1719      3438   +1719     
=============================================
  Files            180       360    +180     
  Lines           4662      9324   +4662     
=============================================
+ Hits            4662      9324   +4662     
Files Coverage Δ
...es/framework/src/Console/Commands/ServeCommand.php 100.00% <ø> (ø)

... and 180 files with indirect coverage changes

@caendesilva caendesilva merged commit e13e215 into master Nov 11, 2023
14 checks passed
@caendesilva caendesilva deleted the fancy-serve-command branch November 11, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant