Refactor internal configuration loader and remove experimental Phar support #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to support when inside the Phar, as we can use the default config location.
This is because it is no longer needed, thanks to 55c8090
caendesilva
force-pushed
the
refactor-internal-phar-support
branch
from
3d653ba to
9759ad8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1485 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1734 3468 +1734
=============================================
Files 180 360 +180
Lines 4702 9402 +4700
=============================================
+ Hits 4702 9402 +4700 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Only inject custom app config location when missing from parent
This makes it easier to support when inside the Phar, as we can use the default config location.
Remove experimental Phar support from internal configuration loader
This is because it is no longer needed, thanks to 55c8090