Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug failing browser tests #1487

Closed
wants to merge 1 commit into from
Closed

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Dec 9, 2023
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (056d08e) 100.00% compared to head (5ebfd5e) 100.00%.

Additional details and impacted files
@@              Coverage Diff              @@
##              master     #1487     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1740      3480   +1740     
=============================================
  Files            180       360    +180     
  Lines           4715      9430   +4715     
=============================================
+ Hits            4715      9430   +4715     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva
Copy link
Member Author

We'll want to fix an older version. See percy/cli#1459 (comment)

@caendesilva
Copy link
Member Author

Fixed in upstream percy/cli#1463

@caendesilva caendesilva changed the title Fix failing browser tests Debug failing browser tests Dec 12, 2023
@caendesilva caendesilva deleted the fix-end-to-end-testing branch December 12, 2023 17:39
@caendesilva caendesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant