Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline block display from inline code elements #1525

Merged

Conversation

caendesilva
Copy link
Member

Removes the HydeFront style specified to make inline code tags render as inline-block, instead letting them be the default inline display.

This fixes the visual overflow bug in hydephp/hydefront#65, and improves line height compatibility as the code background now fits to the text instead of taking up the full line height. This also desirably removes the extra background above the text.

@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Feb 6, 2024
@caendesilva caendesilva marked this pull request as ready for review February 6, 2024 18:13
@caendesilva caendesilva merged commit 5ea0a94 into master Feb 6, 2024
19 checks passed
@caendesilva caendesilva deleted the remove-inline-block-display-from-inline-code-elements branch February 6, 2024 18:14
@caendesilva caendesilva removed the run-visual-tests Internal label to trigger Browserstack visual testing label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant