Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Create new navigation destination class to replace external routes #1636

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Mar 24, 2024

Targets #1568, instead of #1635

This may add too much complexity, and not solve the right problem (as the issue is with ExternalRoutes being hacky, but since they are new and just used in navigation it may be better to improve that instead), but I wanted to visualize what this could look like before making a decision.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (9353eef) to head (ba65f1c).

❗ Current head ba65f1c differs from pull request most recent head 976d7ff. Consider uploading reports for the commit 976d7ff to get more accurate results

Additional details and impacted files
@@                         Coverage Diff                         @@
##             improved-navigation-internals    #1636      +/-   ##
===================================================================
+ Coverage                            99.85%   99.87%   +0.02%     
- Complexity                            1783     1787       +4     
===================================================================
  Files                                  185      185              
  Lines                                 4812     4816       +4     
===================================================================
+ Hits                                  4805     4810       +5     
+ Misses                                   7        6       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva changed the title [2.x] Create new navigation destination class [2.x] Create new navigation destination class to replace external routes Mar 24, 2024
@caendesilva caendesilva force-pushed the create-new-navigation-destination-class branch from e677fdd to faea07b Compare March 24, 2024 11:59
@caendesilva caendesilva force-pushed the create-new-navigation-destination-class branch from be2a58b to 6a64d13 Compare March 24, 2024 14:38
We need the kernel and config so we can check if the routes exist
@caendesilva caendesilva force-pushed the create-new-navigation-destination-class branch from 69ff9bd to 218590d Compare March 24, 2024 14:44
@caendesilva caendesilva marked this pull request as ready for review March 24, 2024 14:54
@caendesilva caendesilva merged commit 3eca812 into improved-navigation-internals Mar 24, 2024
7 checks passed
@caendesilva caendesilva deleted the create-new-navigation-destination-class branch March 24, 2024 14:55
@caendesilva caendesilva mentioned this pull request Jun 27, 2024
99 tasks
@caendesilva caendesilva added this to the v2 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant