-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Simplify and normalize public navigation APIs #1642
[2.x] Simplify and normalize public navigation APIs #1642
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1642 +/- ##
===================================================================
- Coverage 99.97% 99.97% -0.01%
+ Complexity 1778 1775 -3
===================================================================
Files 184 184
Lines 4799 4791 -8
===================================================================
- Hits 4798 4790 -8
Misses 1 1 ☔ View full report in Codecov by Sentry. |
8263717
to
3bcafeb
Compare
3979fa8
to
1b35793
Compare
e00c3cf
to
b3c87c2
Compare
This reverts commit 2c11b05.
To normalize with the navigation menu types
Consider reopening #1630 but rebased to target this branch |
a23d266
to
bfa64bf
Compare
While the built-in views does not support it (and the generators won't use it), the group class itself now supports containing groups as it's children, allowing developers to utilise the system to create more complex navigation menus.
ca0baad
to
8b2daf0
Compare
5712aed
to
62d6930
Compare
…-design [2.x] Merge trait back into menu class and make navigation groups extend the menu class
c681406
into
improved-navigation-internals
Targets #1568 as I when writing the docs realized that having two
NavigationItem
constructors with differing syntaxes and internal logic adds a ton of complexity for no real reason. This PRprotects the constructor to force a single unified API through the staticunifies the constructor signatures and logic to provide the exact same results regardless of the syntax used.create
method.It also changes navigation groups to use collections instead of an array for the internal state to match the navigation group system.