Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile TailwindCSS for production #1689

Closed
wants to merge 1 commit into from
Closed

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Apr 26, 2024
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (d252970) to head (53dd80e).
Report is 3 commits behind head on master.

Current head 53dd80e differs from pull request most recent head f417480

Please upload reports for the commit f417480 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1689   +/-   ##
=========================================
  Coverage     99.97%   99.97%           
+ Complexity     1745     1744    -1     
=========================================
  Files           181      181           
  Lines          4661     4663    +2     
=========================================
+ Hits           4660     4662    +2     
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva
Copy link
Member Author

After updating a Tailwind minor version, table headers in prose classes are now centered instead of left aligned. Needs to be put in the changelog

image

@caendesilva
Copy link
Member Author

caendesilva commented Apr 26, 2024

Halting as the Tailwind change seems to be unintended. See tailwindlabs/tailwindcss-typography#346

Apparently, cannot unapprove the changes. See https://percy.io/9d5269d1/hydephp/builds/33912142/changed/1856671999https://percy.io/9d5269d1/hydephp/builds/33912142/changed/1856671999

@caendesilva caendesilva added the temporarily-frozen Feature Freeze is currently in effect label Apr 26, 2024
@github-actions github-actions bot force-pushed the compile-tailwindcss branch from 53dd80e to 227a7eb Compare April 28, 2024 14:51
@github-actions github-actions bot force-pushed the compile-tailwindcss branch from 227a7eb to f417480 Compare June 8, 2024 10:51
@caendesilva
Copy link
Member Author

Upstream patch is confirmed to work. tailwindlabs/tailwindcss-typography#346

Hopefully it will get merged soon, otherwise we'll have to put a patch in HydeFront.

@caendesilva
Copy link
Member Author

Superseded by #1689

@caendesilva caendesilva deleted the compile-tailwindcss branch June 30, 2024 17:36
@github-actions github-actions bot removed the run-visual-tests Internal label to trigger Browserstack visual testing label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
temporarily-frozen Feature Freeze is currently in effect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant