Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code to increase code quality and type coverage #1868

Merged
merged 44 commits into from
Jul 17, 2024
+882 −234
Merged

Refactor code to increase code quality and type coverage #1868

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
c4c59c5
Add generic declarations to the base foundation collection class
caendesilva Jul 17, 2024
57d2974
Require Psalm plugin for Laravel
caendesilva Jul 17, 2024
fc6d41a
Enable Psalm plugin for Laravel
caendesilva Jul 17, 2024
aa4ba93
Update phpunit.xml
caendesilva Jul 17, 2024
c0f4693
Update phpspec.xml
caendesilva Jul 17, 2024
7b0081e
Update develop.iml
caendesilva Jul 17, 2024
b402df5
Update php.xml
caendesilva Jul 17, 2024
7a6f90a
Hardcode extended generic template entry
caendesilva Jul 17, 2024
98b7795
Update extends syntax
caendesilva Jul 17, 2024
5a0ce28
Annotate string key
caendesilva Jul 17, 2024
b8af88d
Revert "Annotate string key"
caendesilva Jul 17, 2024
5da0baa
Generate PHPDocs with the generic data
caendesilva Jul 17, 2024
de874b9
Revert "Generate PHPDocs with the generic data"
caendesilva Jul 17, 2024
d90b034
Update generic syntax
caendesilva Jul 17, 2024
a142622
Use extends instead of template extends
caendesilva Jul 17, 2024
f24f63b
Debug Psalm issue
caendesilva Jul 17, 2024
a49ddcb
Revert "Debug Psalm issue"
caendesilva Jul 17, 2024
7615fe5
Mixin the kernel
caendesilva Jul 17, 2024
27e5202
Revert "Mixin the kernel"
caendesilva Jul 17, 2024
c3edbb6
Use lower level access call to try to bypass Psalm issues
caendesilva Jul 17, 2024
4853363
Revert "Use lower level access call to try to bypass Psalm issues"
caendesilva Jul 17, 2024
2e9ab04
Remove type annotations that should be inherited from generics
caendesilva Jul 17, 2024
cf74c2a
Remove facade type annotations that should be inherited from generics
caendesilva Jul 17, 2024
cac80aa
Remove type annotations that should be inherited from generics
caendesilva Jul 17, 2024
17c0dcd
Compress single statement PHPDoc blocks
caendesilva Jul 17, 2024
8a18722
Use more verbose facade access as it should have better IDE support
caendesilva Jul 17, 2024
caf5100
Revert "Use more verbose facade access helper"
caendesilva Jul 17, 2024
7b15b31
Add string cast for constant
caendesilva Jul 17, 2024
2002263
Revert "Add string cast for constant"
caendesilva Jul 17, 2024
52c9985
Replace unnecessary polyfills to prevent them from being installed
caendesilva Jul 17, 2024
a6665fb
Update entry points
caendesilva Jul 17, 2024
edfcb7b
Supress missing constructor issue handler
caendesilva Jul 17, 2024
6c5159b
Add custom Psalm stub to get service container generics
caendesilva Jul 17, 2024
fd21aef
Document the stub
caendesilva Jul 17, 2024
f2a2f14
Introduce local variable
caendesilva Jul 17, 2024
b79b7a3
Annotate the repository type
caendesilva Jul 17, 2024
6963a43
Add custom Psalm stub to get tap helper generics
caendesilva Jul 17, 2024
495a659
Improve the stub
caendesilva Jul 17, 2024
840580d
Revert "Document the stub"
caendesilva Jul 17, 2024
140e38b
Add array shape annotations to the config array
caendesilva Jul 17, 2024
b6e07d4
Annotate enumerated string parameter
caendesilva Jul 17, 2024
9999265
Refactor internal fluent helper methods to be void
caendesilva Jul 17, 2024
7556077
Refactor to inline the add element method
caendesilva Jul 17, 2024
f5d6b6f
Update the stub to add app function generics
caendesilva Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .idea/develop.iml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions .idea/php.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions .idea/phpspec.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .idea/phpunit.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,14 @@
"pestphp/pest-plugin-type-coverage": "^2.8",
"php-parallel-lint/php-parallel-lint": "^1.3",
"phpstan/phpstan": "^1.8",
"psalm/plugin-laravel": "^2.11",
"rector/rector": "^1.2.1",
"squizlabs/php_codesniffer": "^3.7"
},
"replace": {
"symfony/polyfill-php72": "*",
"symfony/polyfill-php80": "*"
},
"conflict": {
"symfony/string": ">=7.0"
},
Expand Down
Loading
Loading