Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routes when adding pages after kernel boot #1870

Closed

Conversation

caendesilva
Copy link
Member

Draft until I figure out if this should target 1.x or 2.x

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f5d6b6f) to head (c31d264).
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master     #1870   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1764      1764           
===========================================
  Files            182       182           
  Lines           4704      4704           
===========================================
  Hits            4704      4704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva
Copy link
Member Author

Closing, you should not do this, change your code to add the page before or during kernel boot.

@caendesilva caendesilva deleted the add-routes-when-adding-pages-after-kernel-boot branch July 21, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant