-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Merge the AssetService directly into the Asset facade #1908
Merged
caendesilva
merged 24 commits into
normalize-the-asset-api
from
merge-asset-service-into-asset-facade
Jul 26, 2024
Merged
[2.x] Merge the AssetService directly into the Asset facade #1908
caendesilva
merged 24 commits into
normalize-the-asset-api
from
merge-asset-service-into-asset-facade
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
e8cc1a4
to
6cf6362
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1908 +/- ##
===========================================================
Coverage 100.00% 100.00%
+ Complexity 1875 1874 -1
===========================================================
Files 192 191 -1
Lines 4951 4948 -3
===========================================================
- Hits 4951 4948 -3 ☔ View full report in Codecov by Sentry. |
bf8e809
to
f0192f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify Asset API by Merging AssetService into Asset Facade
This PR simplifies the Asset API by removing the
AssetService
class and moving all its functionality directly into theAsset
facade. This change reduces complexity by removing an unnecessary layer of abstraction. This is part of #1904Changes Made
AssetService
classAsset
facade to implement all functionality directly using static methodsMotivation
This change is part of our ongoing effort to simplify the Hyde API and improve performance. By removing the
AssetService
class, we've eliminated an unnecessary abstraction layer while maintaining all existing functionality. We do lose the ability to swap the facade root for a mock, but this is such a slim use case that has little benefit,