Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Merge the AssetService directly into the Asset facade #1908

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jul 26, 2024

Simplify Asset API by Merging AssetService into Asset Facade

This PR simplifies the Asset API by removing the AssetService class and moving all its functionality directly into the Asset facade. This change reduces complexity by removing an unnecessary layer of abstraction. This is part of #1904

Changes Made

  • Removed AssetService class
  • Updated Asset facade to implement all functionality directly using static methods
  • Updated and renamed relevant test files

Motivation

This change is part of our ongoing effort to simplify the Hyde API and improve performance. By removing the AssetService class, we've eliminated an unnecessary abstraction layer while maintaining all existing functionality. We do lose the ability to swap the facade root for a mock, but this is such a slim use case that has little benefit,

@caendesilva caendesilva mentioned this pull request Jul 26, 2024
21 tasks
@caendesilva caendesilva force-pushed the merge-asset-service-into-asset-facade branch 2 times, most recently from e8cc1a4 to 6cf6362 Compare July 26, 2024 11:38
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (97c7b5a) to head (f0192f5).

Additional details and impacted files
@@                     Coverage Diff                     @@
##             normalize-the-asset-api     #1908   +/-   ##
===========================================================
  Coverage                     100.00%   100.00%           
+ Complexity                      1875      1874    -1     
===========================================================
  Files                            192       191    -1     
  Lines                           4951      4948    -3     
===========================================================
- Hits                            4951      4948    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the merge-asset-service-into-asset-facade branch from bf8e809 to f0192f5 Compare July 26, 2024 12:08
@caendesilva caendesilva marked this pull request as ready for review July 26, 2024 12:13
@caendesilva caendesilva merged commit 9b395d9 into normalize-the-asset-api Jul 26, 2024
7 checks passed
@caendesilva caendesilva deleted the merge-asset-service-into-asset-facade branch July 26, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant