Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Upgrade to use Dusk 8 #1929

Merged
merged 3 commits into from
Aug 2, 2024
+44 −52
Merged

Internal: Upgrade to use Dusk 8 #1929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1edf513
Upgrade to use Dusk 8
caendesilva Aug 2, 2024
39eaecf
Merge branch 'master' into dusk-testing
caendesilva Aug 2, 2024
e71ba11
Fix branch aliases
caendesilva Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 41 additions & 45 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/testing/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"require": {
"php": "^8.0",
"illuminate/support": "^10.0",
"laravel/dusk": "^7.11.3",
"laravel/dusk": "^8.2.2",
"mockery/mockery": "^1.4.4",
"pestphp/pest": "^v2.1.0",
"ext-dom": "*",
Expand Down
8 changes: 2 additions & 6 deletions packages/testing/src/DuskTestCase.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,21 +137,17 @@ protected function driver()

/**
* Determine whether the Dusk command has disabled headless mode.
*
* @return bool
*/
protected function hasHeadlessDisabled()
protected function hasHeadlessDisabled(): bool
{
return isset($_SERVER['DUSK_HEADLESS_DISABLED']) ||
isset($_ENV['DUSK_HEADLESS_DISABLED']);
}

/**
* Determine if the browser window should start maximized.
*
* @return bool
*/
protected function shouldStartMaximized()
protected function shouldStartMaximized(): bool
{
return isset($_SERVER['DUSK_START_MAXIMIZED']) ||
isset($_ENV['DUSK_START_MAXIMIZED']);
Expand Down