Internal: Test code refactors and cleanup #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1958 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1766 1766
===========================================
Files 182 182
Lines 4707 4707
===========================================
Hits 4707 4707 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
test-cleanup
branch
from
3eba37c to
d4eff58
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
26372b2 to
a3cae27
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
a6c8bf7 to
6c0b780
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
37cb095 to
2a01eea
Compare
caendesilva
force-pushed
the
test-cleanup
branch
2 times, most recently
from
f7ee783 to
80a94d9
Compare
This does not work, and is not worth fixing as the setup kernel time amounts to 0.002ms per run, which is 2ms for the entire unit test suite of just over 1000 tests, and only a subset of those even use this.
caendesilva
force-pushed
the
test-cleanup
branch
from
80a94d9 to
6f57ffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.