Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Refactor HydeFront styles to TailwindCSS #2024

Merged
merged 110 commits into from
Nov 17, 2024

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Nov 15, 2024

Abstract

We are updating how HydeFront is handled for v2. Instead of declaring styles directly in HydeFront alongside Tailwind, we will refactor those styles into Tailwind.

HydeFront will serve two main purposes:

  1. It will continue to include the precompiled app.css file bundled with new apps, available through the HydeFront CDN.
  2. It will act as a component library, allowing users to include granular styles from app.css, which we will preconfigure.

For example, users can include our Tailwind styles granularly using just the app.css file from the HydeFront package. This file will be compiled alongside Tailwind. If users prefer customization, they can remove the import and add the specific styles they want.

Todo: Test that checks if config files are matching should test the Tailwind config

Related Changes

I think changelog in many parts can be summarized as:

  • Refactored several Blade components to use Tailwind instead of custom HydeFront CSS code

@caendesilva caendesilva mentioned this pull request Nov 15, 2024
17 tasks
@caendesilva caendesilva changed the title Refactor HydeFront styles to Tailwind [2.x] Refactor HydeFront styles to Tailwind Nov 15, 2024
@caendesilva caendesilva added the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 15, 2024
@caendesilva caendesilva force-pushed the refactor-hydefront-styles-to-tailwind branch from 5a34e99 to 4e2fa27 Compare November 15, 2024 18:40
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9598933) to head (7e65fd6).
Report is 111 commits behind head on new-asset-system.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             new-asset-system     #2024   +/-   ##
====================================================
  Coverage              100.00%   100.00%           
  Complexity               1906      1906           
====================================================
  Files                     195       195           
  Lines                    5078      5080    +2     
====================================================
+ Hits                     5078      5080    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caendesilva caendesilva force-pushed the refactor-hydefront-styles-to-tailwind branch from 4e2fa27 to a1c530f Compare November 15, 2024 19:26
@caendesilva caendesilva force-pushed the refactor-hydefront-styles-to-tailwind branch from a1c530f to b9578a7 Compare November 15, 2024 19:35
@caendesilva caendesilva force-pushed the refactor-hydefront-styles-to-tailwind branch from b9578a7 to 712cf95 Compare November 16, 2024 10:33
@caendesilva
Copy link
Member Author

There are going to be some tiny visual regressions/changes, so I'm going to tackle all of those later. Want to get the main refactor done first.

resources/assets/app.css Outdated Show resolved Hide resolved
resources/assets/app.css Outdated Show resolved Hide resolved
@caendesilva caendesilva marked this pull request as ready for review November 17, 2024 18:09
@caendesilva caendesilva merged commit 2bbd623 into new-asset-system Nov 17, 2024
8 checks passed
@caendesilva caendesilva deleted the refactor-hydefront-styles-to-tailwind branch November 17, 2024 18:09
@caendesilva caendesilva changed the title [2.x] Refactor HydeFront styles to Tailwind [2.x] Refactor HydeFront styles to TailwindCSS Nov 17, 2024
@github-actions github-actions bot removed the run-visual-tests Internal label to trigger Browserstack visual testing label Nov 17, 2024
@caendesilva caendesilva mentioned this pull request Dec 10, 2024
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant