-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Semantic Tailwind Markdown heading permalinks #2052
Merged
caendesilva
merged 10 commits into
custom-markdown-heading-renderer
from
semantic-markdown-heading-permalinks
Dec 5, 2024
Merged
[2.x] Semantic Tailwind Markdown heading permalinks #2052
caendesilva
merged 10 commits into
custom-markdown-heading-renderer
from
semantic-markdown-heading-permalinks
Dec 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## custom-markdown-heading-renderer #2052 +/- ##
====================================================================
Coverage 100.00% 100.00%
Complexity 1928 1928
====================================================================
Files 196 196
Lines 5125 5125
====================================================================
Hits 5125 5125 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
semantic-markdown-heading-permalinks
branch
from
December 4, 2024 08:41
24af854
to
e7be152
Compare
caendesilva
changed the title
[2.x] Semantic markdown heading permalinks
[2.x] Semantic Markdown heading permalinks
Dec 4, 2024
caendesilva
force-pushed
the
semantic-markdown-heading-permalinks
branch
from
December 5, 2024 09:40
1310621
to
af9f4fa
Compare
caendesilva
changed the title
[2.x] Semantic Markdown heading permalinks
[2.x] Semantic Tailwind Markdown heading permalinks
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages:
id
directly ties to the heading itself, which aligns well with HTML5 standards.id
with the heading content.id
for custom styles.See #2047 (comment)