-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Normalize Markdown heading identifiers #2059
Merged
caendesilva
merged 23 commits into
new-asset-system
from
normalize-markdown-heading-identifiers
Dec 7, 2024
Merged
[2.x] Normalize Markdown heading identifiers #2059
caendesilva
merged 23 commits into
new-asset-system
from
normalize-markdown-heading-identifiers
Dec 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With fixtures from Laravel Framework test for the `Str::slug` helper
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## new-asset-system #2059 +/- ##
====================================================
Coverage 100.00% 100.00%
- Complexity 1931 1932 +1
====================================================
Files 196 196
Lines 5139 5141 +2
====================================================
+ Hits 5139 5141 +2 ☔ View full report in Codecov by Sentry. |
This reverts commit 9784937.
Adds only ~0.20ms for the entire dataprovider set, so I think this small thing is worth it
Found that decoding and reescaping is the most reliable and easiest method, and it has virtually no performance impact
caendesilva
changed the title
[2.x] Normalize markdown heading identifiers
[2.x] Normalize Markdown heading identifiers
Dec 7, 2024
caendesilva
force-pushed
the
normalize-markdown-heading-identifiers
branch
from
December 7, 2024 21:44
3dfcdf7
to
50f89f8
Compare
caendesilva
added a commit
that referenced
this pull request
Dec 22, 2024
Want to match #2059, but that would change output so deferring to v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the heading identifier generation to improve how heading slugs/IDs are created. The key changes include:
Replacing the simple
Str::slug()
method with a more robustmakeIdentifier()
method in theHeadingRenderer
class.Adding more comprehensive normalization of heading text:
Ensure the identifier works consistently across different types of input, including:
Added comprehensive unit tests to verify the new identifier generation works correctly for a wide range of input scenarios.
The goal is creating more predictable and clean URL-friendly identifiers for headings in markdown documents, while maintaining readability and handling internationalization.