-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Interactive component publisher command #2062
Draft
caendesilva
wants to merge
74
commits into
2.x-dev
Choose a base branch
from
interactive-component-publisher-command
base: 2.x-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+461
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #2062 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 1947 1964 +17
===========================================
Files 197 198 +1
Lines 5187 5249 +62
===========================================
+ Hits 5187 5249 +62 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
interactive-component-publisher-command
branch
7 times, most recently
from
December 11, 2024 20:54
8a13956
to
b0cf6de
Compare
caendesilva
force-pushed
the
interactive-component-publisher-command
branch
6 times, most recently
from
December 22, 2024 18:36
c0013d8
to
8ab499e
Compare
Really wish there was a button option like in the original PR laravel/prompts#147
This pre-evaluates the check Laravel Prompts makes, to ensure we don't use their fallback.
This reverts commit ab6ef83.
caendesilva
force-pushed
the
interactive-component-publisher-command
branch
from
December 22, 2024 20:08
b2d42ab
to
540c0c4
Compare
caendesilva
force-pushed
the
interactive-component-publisher-command
branch
2 times, most recently
from
December 22, 2024 20:43
adb7279
to
2438471
Compare
caendesilva
force-pushed
the
interactive-component-publisher-command
branch
from
December 23, 2024 18:44
b09a310
to
1cabc8b
Compare
caendesilva
commented
Dec 23, 2024
* | ||
* @param array<string> $selectedFiles | ||
*/ | ||
public function formatOutput(array $selectedFiles): string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this too far?
- All files (10): "Published all files, including [app.blade.php, docs.blade.php, footer.blade.php] and 7 more"
- Many files (7): "Published files [app.blade.php, docs.blade.php, footer.blade.php] and 4 more"
- Multiple files (3): "Published files [app.blade.php, docs.blade.php, footer.blade.php]"
- Single file (1): "Published file [app.blade.php]"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.