fix: fixing seeding on level #1444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses inconsistencies in the game seeding functionality by modifying the download status management in the level database.
- Fixed status tracking in
/src/main/events/torrenting/resume-game-seed.tsby setting explicit "seeding" state when resuming - Potential race condition in
resume-game-seed.tswhereDownloadManager.resumeSeeding()uses stale download object - Inconsistent status handling in
/src/main/events/torrenting/pause-game-seed.tsusing "complete" instead of a paused state - Modified download state access pattern in
/src/renderer/src/pages/downloads/download-group.tsxto use game.download reference
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
…alauncher/hydra into fix/fixing-seeding-on-level
|
zamitto
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content: