Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't process solid if no csg #1055

Merged
merged 1 commit into from
Nov 13, 2023
Merged

don't process solid if no csg #1055

merged 1 commit into from
Nov 13, 2023

Conversation

wynged
Copy link
Member

@wynged wynged commented Nov 10, 2023

BACKGROUND:

  • I wasn't getting any stuff when making elbows because I had a non-null representation that was empty. this caused errors during the code for getting render data for element. we previously wouldn't notice these errors because we wouldn't expect to see any geometry, but now with the alternative path of RepresentationInstances we might expect to see geometry in these cases.

DESCRIPTION:

  • add a _csg==null check

TESTING:

  • no behavior change.

FUTURE WORK:

  • Is there any future work needed or anticipated? Does this PR create any obvious technical debt?

REQUIRED:

  • All changes are up to date in CHANGELOG.md.

COMMENTS:

  • Any other notes.

This change is Reviewable

Copy link
Contributor

@katehryhorenko katehryhorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@wynged wynged merged commit 1db3e1f into master Nov 13, 2023
1 check passed
@wynged wynged deleted the check-if-null-csg branch November 13, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants