Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/image loading errors #1145

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,21 +47,23 @@ jobs:
- uses: KengoTODA/actions-setup-docker-compose@v1
with:
version: '2.18.1'

- name: Setup pnpm
uses: pnpm/action-setup@v2
with:
version: 8.9.0
- name: Set up Node.js 18
uses: actions/setup-node@v3
with:
node-version: "18.15.0"
cache: "yarn"

cache: "pnpm"
- name: Run e2e tests
run: |
env && yarn e2e:ci-run-tests
env && pnpm run e2e:ci-run-tests

- name: Output logs
if: always()
run: |
yarn e2e:ci-logs > e2e.ci.log
pnpm run e2e:ci-logs > e2e.ci.log

- name: Save logs
if: always()
Expand Down
2 changes: 1 addition & 1 deletion cors-proxy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"@cloudflare/workers-types": "^4.20230115.0",
"typescript": "^4.9.5",
"vitest": "^0.28.4",
"wrangler": "2.9.1"
"wrangler": "3.15.0"
},
"private": true,
"scripts": {
Expand Down
5 changes: 4 additions & 1 deletion cors-proxy/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,10 @@ export default {
const apiUrl = url.searchParams.get(QUERYSTRING_KEY);

if (apiUrl == null) {
return new Response(`Missing GET parameter: ${QUERYSTRING_KEY}`);
return new Response(`Missing GET parameter: ${QUERYSTRING_KEY}`, {
status: 400,
statusText: `Bad Request: ${QUERYSTRING_KEY} param undefined`,
});
}

// Rewrite request to point to API URL. This also makes the request mutable
Expand Down
Loading
Loading