fix: bugs with showing non otel spans (ex. clickhouse opentelemetry span logs) #789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MikeShi42
changed the title
knudtty
reviewed
May 5, 2025
| @@ -619,6 +622,21 @@ export function TraceTableModelForm({ | |||
| placeholder="SpanAttributes" | |||
| /> | |||
| </FormRow> | |||
| <FormRow | |||
| label={'Span Events Value Expression'} | |||
| helpText="Expression to extract span events. Used to capture events associated with spans. Expected to be Nested ( Timestamp DateTime64(9), Name LowCardinality(String), Attributes Map(LowCardinality(String), String)" | |||
There was a problem hiding this comment.
This shows up very long and almost runs off the screen. Could we throw a maxwidth + text wrap on this element?
MikeShi42
force-pushed
the
mikeshi/fix-non-otel-spans
branch
from
a09e926 to
4b88067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing a few bugs that prevented us from properly rendering trace view for
system.opentelemetry_span_logfix HDX-1676