Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport #737 to 0.3.x #738

Merged

Conversation

Noah-Kennedy
Copy link
Contributor

No description provided.

This change causes GOAWAYs to be issued to misbehaving connections which for one reason or another cause us to emit lots of error resets.

Error resets are not generally expected from valid implementations anyways.

The threshold after which we issue GOAWAYs is tunable, and will default to 1024.
@Noah-Kennedy Noah-Kennedy force-pushed the noah/backport-limit-error-resets branch from 135b27a to 6348eae Compare January 17, 2024 19:08
@Noah-Kennedy Noah-Kennedy changed the title chore: backport 59570e11ccddbec85f67a0c7aa353f7730c68854 chore: backport #737 Jan 17, 2024
@Noah-Kennedy Noah-Kennedy changed the title chore: backport #737 chore: backport #737 to 0.3.x Jan 17, 2024
@seanmonstar seanmonstar merged commit d919cd6 into hyperium:0.3.x Jan 17, 2024
7 checks passed
@Noah-Kennedy Noah-Kennedy deleted the noah/backport-limit-error-resets branch January 17, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants