Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ci/h2spec.sh (macOS compat, /tmp dir and overwrite) #809

Merged
merged 1 commit into from
Nov 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions ci/h2spec.sh
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
#!/bin/bash
LOGFILE="h2server.log"
LOGFILE="/tmp/h2server.log"

if ! [ -e "h2spec" ] ; then
override_h2spec=false

# Check for optional flag
while getopts "F" opt; do
case $opt in
F) override_h2spec=true ;;
*) echo "Usage: $0 [-o]"; exit 1 ;;
esac
done

if ! [ -e "/tmp/h2spec" ] || $override_h2spec ; then
# if we don't already have a h2spec executable, wget it from github
wget https://github.com/summerwind/h2spec/releases/download/v2.1.1/h2spec_linux_amd64.tar.gz
tar xf h2spec_linux_amd64.tar.gz
if [[ "$OSTYPE" == "darwin"* ]]; then
curl -L -o /tmp/h2spec_darwin_amd64.tar.gz https://github.com/summerwind/h2spec/releases/download/v2.1.1/h2spec_darwin_amd64.tar.gz \
&& tar xf /tmp/h2spec_darwin_amd64.tar.gz -C /tmp
else
curl -L -o /tmp/h2spec_linux_amd64.tar.gz https://github.com/summerwind/h2spec/releases/download/v2.1.1/h2spec_linux_amd64.tar.gz \
&& tar xf /tmp/h2spec_linux_amd64.tar.gz -C /tmp
fi
fi

cargo build --example server
Expand All @@ -16,7 +31,7 @@ SERVER_PID=$!
sed '/listening on Ok(127.0.0.1:5928)/q' <&3 ; cat <&3 > "${LOGFILE}" &

# run h2spec against the server, printing the server log if h2spec failed
./h2spec -p 5928
/tmp/h2spec -p 5928
H2SPEC_STATUS=$?
if [ "${H2SPEC_STATUS}" -eq 0 ]; then
echo "h2spec passed!"
Expand Down