Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tone down debugs from codec modules #820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lthiery
Copy link

@lthiery lthiery commented Nov 25, 2024

Some logging frameworks don't really tolerate module level configurations well. I have quite a broad project but h2 seems to be the only dependency that has such chatty debug settings.

Would you be open-minded to removing all debug! in favor of trace!?

@seanmonstar
Copy link
Member

This library already has a lot of noise at the trace level, the things at debug level are indeed helpful for many people to debug without needing the full firehose.

I don't think the solution is to reduce the helpfulness of the logs for those people, but to use a logger that allows you to adjust specific libraries if you don't want their logs.

@lthiery
Copy link
Author

lthiery commented Nov 25, 2024

I'm still trying to fix that but this is also the only crate that's causing so much chattiness. Perhaps if just the "send" in frame_write and "read" in frame_read could be downgraded?

@lthiery lthiery changed the title tone down all debug to trace tone down debugs from codec modules Dec 12, 2024
@lthiery
Copy link
Author

lthiery commented Dec 12, 2024

@seanmonstar checking in to see if this level of change would acceptable? the scope has been narrowed to only the messages that I believe are very chatty. I do agree that a logging system should be capable of tuning logs per module, but I also believe that debug logging should be a little less active than h2 is with these two instances.

Of course, up to you and will close and move on if you're not into it. Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants