Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add {http1,http2}_only for auto conn #111

Merged
merged 1 commit into from
May 24, 2024

Conversation

dswij
Copy link
Member

@dswij dswij commented Mar 17, 2024

Closes hyperium/hyper#3511

This PR adds an option to choose http1 or http2 only for auto connections.

@dswij dswij force-pushed the issue-3511 branch 3 times, most recently from b29fc46 to a5f37b7 Compare March 18, 2024 08:47
@dswij dswij marked this pull request as ready for review March 18, 2024 16:08
@dswij dswij requested a review from seanmonstar March 18, 2024 18:53
@seanmonstar seanmonstar requested a review from sfackler March 18, 2024 22:02
@seanmonstar
Copy link
Member

@sfackler would this solve your use case?

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Share my opinion on the style issue. In general, I'm OK with either way and let's try to move forward.

src/server/conn/auto.rs Show resolved Hide resolved
@rakshith-ravi
Copy link
Contributor

Hey. Just wanted to check in to see if there's anything that I can do to help push this forward?

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks dswij! Can be merged after conflicts are resolved.

@tisonkun
Copy link
Contributor

@seanmonstar I send a follow-up to resolve the conflict at #124.

It retains @dswij's credit. Hopefully we can move forward and my major target is to help hyperium/tonic#1670 done.

@tisonkun
Copy link
Contributor

tisonkun commented May 24, 2024

@seanmonstar This patch has some uncompleted part. I fix it up at 582cd9f and you can review #124.

@seanmonstar seanmonstar merged commit 1635bcc into hyperium:master May 24, 2024
16 checks passed
@dswij dswij deleted the issue-3511 branch May 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyper-util: Add a version of conn::auto that doesn't need to read the version
6 participants