fix(client): Fix HTTP/2 websocket request
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x676e67
changed the title
HTTP/2 upgrade WebSocketHTTP/2 WebSocket request
0x676e67
changed the title
HTTP/2 WebSocket requestHTTP/2 websocket request
|
Wow, nice detective work! Would you be up to adding a legacy test after If you don't have time, I can get to it eventually. |
|
OK, I'll do this. |
|
I’ve added a new HTTP/2 upgrade test. If you need anything else, feel free to let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking: hyperium/hyper#3840
Through debugging, it is found that HTTP/2 CONNECT is treated as HTTP/1.1 CONNECT and the request path is processed. Comment this part of the code and the handshake is normal
According to RFC 8841, the example must carry the
:pathpseudo-headerThis is the simplest fix, I don't know if there is something else I'm missing