-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add middleware doc for server #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewbMiao
force-pushed
the
add-middleware
branch
from
February 3, 2024 01:31
725f6d9
to
da2e6e9
Compare
Fixed and verified test locally. |
dswij
reviewed
Feb 3, 2024
NewbMiao
force-pushed
the
add-middleware
branch
from
February 23, 2024 12:58
d0a6dce
to
7237298
Compare
dswij
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @NewbMiao! Improving the documentation is really a huge help.
@NewbMiao Can you help to add an entry on _data so that the new guide will show up in navigation bar? also, can you rebase it to latest master? I will merge this afterward |
NewbMiao
commented
Mar 9, 2024
dswij
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add middleware doc after hyper not dependents on the tower crate.
Related discussion: hyperium/hyper#3154