Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add middleware doc for server #116

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Conversation

NewbMiao
Copy link
Contributor

@NewbMiao NewbMiao commented Feb 2, 2024

Add middleware doc after hyper not dependents on the tower crate.

Related discussion: hyperium/hyper#3154

@NewbMiao NewbMiao changed the title add middleware for server add middleware doc for server Feb 2, 2024
@NewbMiao
Copy link
Contributor Author

NewbMiao commented Feb 3, 2024

Fixed and verified test locally.

_stable/server/middleware.md Outdated Show resolved Hide resolved
_stable/server/middleware.md Show resolved Hide resolved
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NewbMiao! Improving the documentation is really a huge help.

@dswij
Copy link
Member

dswij commented Mar 4, 2024

@NewbMiao Can you help to add an entry on _data so that the new guide will show up in navigation bar? also, can you rebase it to latest master?

https://github.com/hyperium/hyperium.github.io/blob/281f5d579b6b6f21bf696e7aab6683d393b82db2/_data/stable.yml

I will merge this afterward

@dswij dswij merged commit 2d3bfe3 into hyperium:master Mar 9, 2024
3 checks passed
@NewbMiao NewbMiao deleted the add-middleware branch March 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants