feat: middleware submission tweaks #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-savu
force-pushed
the
dan/wip-escalate-before-broadcast
branch
from
693f9de to
ac7b7c9
Compare
daniel-savu
changed the title
ameten
approved these changes
Jan 3, 2025
tkporter
approved these changes
Jan 3, 2025
daniel-savu
added a commit
that referenced
this pull request
Jan 9, 2025
This reverts commit f18abe3.
daniel-savu
added a commit
that referenced
this pull request
Jan 9, 2025
daniel-savu
added a commit
that referenced
this pull request
Jan 9, 2025
daniel-savu
added a commit
that referenced
this pull request
Jan 10, 2025
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
Jan 13, 2025
### Description Uses the short-term fixes described in this [design doc](https://www.notion.so/hyperlanexyz/State-of-EVM-provider-middleware-16c6d35200d680d8a6b5f0d32cd8c66b?pvs=4) and implemented in hyperlane-xyz/ethers-rs#23 These fixes are expected to make the relayer self-recover from nonce gaps. An expected drawback is that tx hashes are dropped more often due to the nonce manager resyncing to nonces that end up being too low by 1, which can slow down submissions. After 12h of testing, any submit queue spikes were only 1 min long and the biggest one had 7 messages - so short enough not to trigger the "rising submit queue" alert which stays pending for 6min: https://abacusworks.grafana.net/alerting/de6hwplr7eakgc ### Drive-by changes - Removes verbosity from a bunch of logs (we had `HyperlaneMessage` in a single log occur 6-7 times, but wasn't noticeable in `span`s because it was originating from args named `message` which have a clash with inner workings of the `tracing` lib) - rewords some logs because they were misleading ### Related issues Fixes: #5107 ### Backward compatibility Yes ### Testing E2E with a gas escalator that randomly dropped every other tx - the nonce manager was able to recover but was slower to submit. Then evaluated on RC for 12h as described above.
fmorency
pushed a commit
to fmorency/hyperlane-agents
that referenced
this pull request
Feb 20, 2025
### Description Uses the short-term fixes described in this [design doc](https://www.notion.so/hyperlanexyz/State-of-EVM-provider-middleware-16c6d35200d680d8a6b5f0d32cd8c66b?pvs=4) and implemented in hyperlane-xyz/ethers-rs#23 These fixes are expected to make the relayer self-recover from nonce gaps. An expected drawback is that tx hashes are dropped more often due to the nonce manager resyncing to nonces that end up being too low by 1, which can slow down submissions. After 12h of testing, any submit queue spikes were only 1 min long and the biggest one had 7 messages - so short enough not to trigger the "rising submit queue" alert which stays pending for 6min: https://abacusworks.grafana.net/alerting/de6hwplr7eakgc ### Drive-by changes - Removes verbosity from a bunch of logs (we had `HyperlaneMessage` in a single log occur 6-7 times, but wasn't noticeable in `span`s because it was originating from args named `message` which have a clash with inner workings of the `tracing` lib) - rewords some logs because they were misleading ### Related issues Fixes: hyperlane-xyz/hyperlane-monorepo#5107 ### Backward compatibility Yes ### Testing E2E with a gas escalator that randomly dropped every other tx - the nonce manager was able to recover but was slower to submit. Then evaluated on RC for 12h as described above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
both are short-term fixes for the issues dicussed in https://www.notion.so/hyperlanexyz/State-of-EVM-provider-middleware-16c6d35200d680d8a6b5f0d32cd8c66b?pvs=4