Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): checker remoteRouters check fix #5604

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Mar 5, 2025

Description

This fixes the warp check command because it did not correctly check the remoteRouters object when included in the config. The issue was caused by the normalizeConfig function, which removes occurrences of the address field from an object. This converted the remoteRouter config to an empty object, causing the check to succeed when it shouldn't have.

image

A new HypTokenRouterConfigToCheck type has been implemented, which renames the field to routerAddress for checking purposes

image

Drive-by changes

  • None

Related issues

Backward compatibility

  • YES

Testing

  • Manual
  • E2E

@xeno097 xeno097 requested review from yorhodes and ltyu as code owners March 5, 2025 13:57
Copy link

changeset-bot bot commented Mar 5, 2025

🦋 Changeset detected

Latest commit: 6b11a39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/utils Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xeno097 xeno097 requested a review from nambrot March 5, 2025 13:57
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (396d61b) to head (6b11a39).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5604   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@xeno097 xeno097 requested a review from paulbalaji March 5, 2025 14:16
@xeno097 xeno097 marked this pull request as draft March 5, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant