Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow explorer to be hosted in a subdirectory #448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

daanporon
Copy link

What this PR does / why we need it:

Currently the Hyperledger explorer can only be hosted at the root of a domain name. With this change it's possible to also host it at a subdirectory of a domain for example: https://example.com/your-fabric-explorer-instance.

In order to allow this i added the "homepage" property to the package.json as is described in the create-react-app documentation. By using "." for the homepage you it will always fetch the static files relative too where the explorer is being hosted, this way you don't need to change anything at build time.

Next to that i also changed the location of the api operations to use relative urls as well. This works since a hash-based routing is currently being used.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation, usage docs, etc.:


@daanporon daanporon requested a review from a team as a code owner September 12, 2023 12:41
feat/allow-to-be-hosted-in-subpath

Signed-off-by: Daan Poron <[email protected]>
@daanporon daanporon force-pushed the feat/allow-to-be-hosted-in-subpath branch from 46e57d7 to 3968a3f Compare September 12, 2023 13:14
@suumona
Copy link
Contributor

suumona commented Nov 10, 2023

hi @daanporon,
Thanks for the PR. After adding the file changes, the Explorer application isn't reflecting the modifications. To ensure clarity, could you please provide screenshots demonstrating the Explorer being hosted in a subdirectory

@daanporon
Copy link
Author

daanporon commented Nov 10, 2023

Hi @suumona, this is what i mean. We are using a /insights/some-name url.

Screenshot 2023-11-10 at 15 32 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants