Fix the build: Run integration tests with golang 1.18, ginkgo v2.1.4, and gomega v1.19 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Kneubuhl <[email protected]>
jkneubuh
force-pushed
the
feature/go-1.18
branch
from
50fd959
to
401a048
Compare
Signed-off-by: Josh Kneubuhl <[email protected]>
jkneubuh
changed the title
Signed-off-by: Josh Kneubuhl <[email protected]>
|
This is / was a real mess. running With this PR, the integration tests now run with golang 1.18. The ginkgo binary installs at the latest v2.1.4, but using the older gomega v1.19.0 as specified in the go.mod. PR #64 needs some work to sort out all of the dependencies - it forces an update of controller-gen, fabric-ca, and logging, which are all intertwined with some odd relationship based on code that may or may not be in the latest 1.5 CA. |
asararatnakar
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent ginkgo update requires golang 1.18. This PR fixes the build pipeline, which was pinning the test version to 1.17.
Signed-off-by: Josh Kneubuhl [email protected]