New Idemix Integration with W3C support, preparation #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale-linux
requested changes
Aug 12, 2024
| func NewDeserializerWithBCCSP(ipk []byte, verType csp.VerificationType, nymEID []byte, cryptoProvider csp.BCCSP) (*Deserializer, error) { | ||
| func NewDeserializerWithBCCSP( | ||
| sm SchemaManager, | ||
| schema string, |
There was a problem hiding this comment.
Imho the deserializer shouldn't know anything about the schema at construction time. Info on the schema type should come later through the normal APIs from the protobuf data. This is why in the initial implementation I had cached the value of the public key and only decided to parse it later as soon as the schema type was known through the proper channels. See here where I cached it and here where I deferred the parsing of the IPK.
adecaro
changed the title
adecaro
force-pushed
the
f-new-idemix
branch
from
0c11276
to
7f85de4
Compare
adecaro
force-pushed
the
f-new-idemix
branch
from
7f85de4
to
e2b61d1
Compare
adecaro
force-pushed
the
f-new-idemix
branch
from
bfd0e91
to
59a0de2
Compare
Use the `SerializedIdemixIdentity` proto definition from the idemix repo and not from fabric, whence idemix has been removed. Signed-off-by: Alessandro Sorniotti <[email protected]> Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
Signed-off-by: Angelo De Caro <[email protected]>
adecaro
force-pushed
the
f-new-idemix
branch
from
59a0de2
to
56a85c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: