Enhanced Redeem #990
Open
Enhanced Redeem #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bar haim <[email protected]>
Signed-off-by: bar haim <[email protected]>
Signed-off-by: bar haim <[email protected]>
Signed-off-by: bar haim <[email protected]>
Signed-off-by: bar haim <[email protected]>
arner
reviewed
Mar 18, 2025
| if len(issuers) < 1 { | ||
| return nil, nil, errors.New("no issuer found") | ||
| } | ||
| issuer := issuers[0] |
There was a problem hiding this comment.
Can it be possible that there is more than one issuer? If so, how do we know which one we have to pick?
There was a problem hiding this comment.
We assumed that it is enough for a single issuer to sign and if there are multiple we take the first. It's about the definition of the flow #890
There was a problem hiding this comment.
Ok I don't know about that, maybe @KElkhiyaoui or @adecaro can confirm :)
There was a problem hiding this comment.
good catch, Arne, we will need to fix this in coming PRs to let the user decide which issuer to choose.
Signed-off-by: bar haim <[email protected]>
This was
linked to
issues
Mar 25, 2025
This was
unlinked from
issues
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration completed using Extra Signers and Binding to pass the Issuer identity